Repository navigation
fix(ci): upload playwright-report from example/'s working directory - #1349
Merged
Merged
Conversation
The Playwright test step runs with working-directory: ./example, so the HTML report lands at example/playwright-report/. The upload-artifact step used a repo-root-relative path (playwright-report/), so every E2E failure silently uploaded nothing - the log showed "No files were found with the provided path" instead of failing loudly. e2e-nightly.yml already had the correct path; pr.yml and ci-main.yml did not. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
Contributor
|
Deploy preview for adp-cost-calculator ready!
Deployed with vercel-action |
Contributor
📊 Coverage Report⚪ Coverage unchanged
Detailed BreakdownLines Coverage
Statements Coverage
Functions Coverage
Branches Coverage
✅ Coverage check passed |
gh pr create only pre-fills .github/pull_request_template.md when no --body/--body-file/--fill is passed - scripting a PR body still needs to read and fill the template explicitly, otherwise it's easy to open a free-form body instead (as happened on #1349). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
jordividaller
approved these changes
Sep 22, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
E2E test failures never uploaded a debuggable Playwright report/trace in CI — the artifact upload silently found no files.
Why
The Playwright test step runs with
working-directory: ./example, so the HTML report is written toexample/playwright-report/. Theupload-artifactstep used a repo-root-relative path (playwright-report/), which never matched. The job log showed:instead of failing loudly, so nobody could pull down a trace for any failed E2E run.
e2e-nightly.ymlalready used the correct path —pr.ymlandci-main.ymldidn't.What changed
Toggle details
.github/workflows/pr.ymland.github/workflows/ci-main.yml:path: playwright-report/→path: example/playwright-report/on theupload-artifactstep in theE2E Testsjob.Screenshots
N/A
Related Resources
Testing
No files were found with the provided path: playwright-report/)Note
Low Risk
Workflow artifact path and contributor documentation only; no application or test logic changes.
Overview
CI: E2E jobs in
pr.ymlandci-main.ymlnow upload Playwright HTML reports fromexample/playwright-report/instead of repo-rootplaywright-report/, matching where tests run (working-directory: ./example). Failed runs should again produce downloadableplaywright-reportartifacts instead of silently uploading nothing.Docs:
CLAUDE.mdadds a convention that PR bodies follow.github/pull_request_template.md, including howgh pr createpicks up the template when scripting PRs.Reviewed by Cursor Bugbot for commit 2516d15. Bugbot is set up for automated code reviews on this repo. Configure here.